Review Request 129119: Fix HAVE_TRUNC cmake check
Ralf Habacker
ralf.habacker at freenet.de
Wed Oct 19 10:27:32 UTC 2016
> On Okt. 19, 2016, 12:12 nachm., Ralf Habacker wrote:
> > I had the same issue with gcc 6.2. I can confirm that the patch fixes the issue.
I would have pushed the related commit into kdelibs repo, but got rejected with the error 'remote: Audit failure - Commit 6157880cf193c1f9f6540f768beadc844d8cff20 - Email address has an invalid domain' showing the full machine hostname. I added my email address registered by KDE into kdelibs/.git/config but still got rejected.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129119/#review100129
-----------------------------------------------------------
On Okt. 7, 2016, 11:05 nachm., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129119/
> -----------------------------------------------------------
>
> (Updated Okt. 7, 2016, 11:05 nachm.)
>
>
> Review request for Build System and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> On newer distros the check fails because trunc is ambiguous, so tell sizeof exactly which trunc we're speaking about.
>
>
> Diffs
> -----
>
> ConfigureChecks.cmake 2729adb
> cmake/modules/CheckPrototypeExists.cmake 811d648
>
> Diff: https://git.reviewboard.kde.org/r/129119/diff/
>
>
> Testing
> -------
>
> kdelibs compiles (a bit more, there's still an unrelated issue)
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161019/ea286841/attachment.html>
More information about the Kde-buildsystem
mailing list