Review Request 129367: Use the generic redirect and add the doc link

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129367/#review100868
-----------------------------------------------------------


Ship it!




I'm not a buildsystem/ECM maintainer but the changes look correct and would improve things, so +1 from me.

- Michael Pyne


On Nov. 15, 2016, 10:53 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129367/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 10:53 a.m.)
> 
> 
> Review request for Build System and Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> https://commits.kde.org/<repo>?path=...&branch=... is guaranteed to redirect to the proper repository browser.
> Add a link to the generated ECM documentation.
> 
> 
> Diffs
> -----
> 
>   README.rst f3e98aa 
>   kde-modules/KDECMakeSettings.cmake 6e53cb1 
> 
> Diff: https://git.reviewboard.kde.org/r/129367/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161116/2ef876be/attachment.html>