Review Request 129316: Add new cmake module `FindLibinotify.cmake`.
Tobias Berner
tcberner at gmail.com
Thu Nov 3 07:30:11 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129316/
-----------------------------------------------------------
Review request for Extra Cmake Modules, Adriaan de Groot, Gleb Popov, and Raphael Kubo da Costa.
Repository: extra-cmake-modules
Description
-------
FreeBSD also has inotify. However it is a library and not a kernel subsystem.
With that change, targets checking for sys/inotify.h could switch from something like
```
option(ENABLE_INOTIFY "Try to use inotify for directory monitoring" ON)
if(ENABLE_INOTIFY)
include(CheckIncludeFiles)
check_include_files(sys/inotify.h SYS_INOTIFY_H_FOUND)
set(HAVE_SYS_INOTIFY_H ${SYS_INOTIFY_H_FOUND})
endif()
```
to
```
option(ENABLE_INOTIFY "Try to use inotify for directory monitoring" ON)
if(ENABLE_INOTIFY)
find_package(Libinotify)
set_package_properties(Libinotify PROPERTIES
PURPOSE "Filesystem alteration notifications using inotify")
set(HAVE_SYS_INOTIFY_H ${LIBINOTIFY_FOUND})
else()
set(HAVE_SYS_INOTIFY_H FALSE)
endif()
```
[from kcoreaddons], and append `${LIBINOTIFY_INCLUDE_DIRS}` to the `include_directories`, aswell as `${LIBINOTIFY_LIBRARIES}` to the link-libraires.
Diffs
-----
find-modules/FindLibinotify.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129316/diff/
Testing
-------
Used in the unofficial KDE FreeBSD ports.
Thanks,
Tobias Berner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161103/f5a0f344/attachment.html>
More information about the Kde-buildsystem
mailing list