Review Request 127910: kdesrc-build: improve error messages by showing the right filename

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127910/
-----------------------------------------------------------

(Updated May 15, 2016, 12:56 p.m.)


Review request for Build System and Michael Pyne.


Changes
-------

Use a stack of filenames. Not exactly the solution you had in mind, but the "basepath" stuff could be refactored to use this new stack if wanted, pushBasePath being internal.


Repository: kdesrc-build


Description
-------

Before:
"Don't use module libaccounts-qt on line 20 of /path/kdesrc-buildrc, use options libaccounts-qt"
 but line 20 is unrelated, some global option.

After:
"Don't use module libaccounts-qt on line 20 of /path/extragear/utils/kdesrc-build/kf5-workspace-build-include, use options libaccounts-qt"


Diffs (updated)
-----

  modules/ksb/Application.pm 5dbd224c7ba06242b53cd77cfa0764c28da76579 
  modules/ksb/RecursiveFH.pm 6892320bb5e8f8c1e4979ef137bb975775940908 

Diff: https://git.reviewboard.kde.org/r/127910/diff/


Testing
-------


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160515/83173475/attachment.html>