Review Request 127910: kdesrc-build: improve error messages by showing the right filename

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127910/#review95456
-----------------------------------------------------------


Fix it, then Ship it!




I'd like an added comment to keep me honest later but looks very good otherwise, thanks for the fix!


modules/ksb/RecursiveFH.pm (line 16)
<https://git.reviewboard.kde.org/r/127910/#comment64717>

    I think I would add a comment here to the effect that we don't maintain a full stack for current_file since we only need current_file when writing out error messages. It will help future me avoid some confusion that I worked through just now. ;)


- Michael Pyne


On May 13, 2016, 7:36 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127910/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 7:36 p.m.)
> 
> 
> Review request for Build System and Michael Pyne.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> Before:
> "Don't use module libaccounts-qt on line 20 of /path/kdesrc-buildrc, use options libaccounts-qt"
>  but line 20 is unrelated, some global option.
> 
> After:
> "Don't use module libaccounts-qt on line 20 of /path/extragear/utils/kdesrc-build/kf5-workspace-build-include, use options libaccounts-qt"
> 
> 
> Diffs
> -----
> 
>   modules/ksb/Application.pm b5bab5a6eb24cba488572dbdbdbabd024db8dc91 
>   modules/ksb/RecursiveFH.pm 6892320bb5e8f8c1e4979ef137bb975775940908 
> 
> Diff: https://git.reviewboard.kde.org/r/127910/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160514/8d0e8dac/attachment.html>