Review Request 127513: ECMEnableSanitizers: avoid linking runtime for Clang

Mathieu Tarral mathieu.tarral at gmail.com
Tue Mar 29 14:33:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127513/#review94107
-----------------------------------------------------------


Ship it!




Ship It!

- Mathieu Tarral


On March 28, 2016, 10:44 a.m., Peter Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127513/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 10:44 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and Mathieu Tarral.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Clang automatically adds its runtime library (librt) when given the
> -fsanitize options. Do not force the GCC runtime libraries (asan, tsan,
> lsan), this results in "Your application is linked against incompatible
> ASan runtimes." errors when using the library in an executable built
> using Clang.
> 
> 
> Diffs
> -----
> 
>   modules/ECMEnableSanitizers.cmake e64599b 
> 
> Diff: https://git.reviewboard.kde.org/r/127513/diff/
> 
> 
> Testing
> -------
> 
> Applied this patch on top of 5.20.0-1 and built Solid 5.20.0-1 with `-DCMAKE_CXX_COMPILER=clang++ -DECM_ENABLE_SANITIZERS=address`. Finally be able to start ASAN-instrumented Wireshark (which was built using Clang).
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160329/e36a4394/attachment.html>


More information about the Kde-buildsystem mailing list