Review Request 128533: Create a test that validates projects' appstream information

[Matthias Klumpp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128533/#review97859
-----------------------------------------------------------




kde-modules/test_appstream.cmake (line 1)
<https://git.reviewboard.kde.org/r/128533/#comment65945>

    I am not 100% sure on how this works, but would it be possible to validate the .desktop file and AppStream XML together?
    For that, we would need an installed copy of the metadata and .desktop files in some directory `$DESTDIR` and then could fire `appstreamcli validate-tree $DESTDIR` at it.
    That command will validate all metainfo files together with the .desktop files and complain on error.



kde-modules/test_appstream.cmake (line 5)
<https://git.reviewboard.kde.org/r/128533/#comment65944>

    The files could also be named `*.metainfo.xml` - it's probably better to validate all XML files in `/usr/share/metainfo` at time...


- Matthias Klumpp


On July 27, 2016, 12:25 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128533/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 12:25 a.m.)
> 
> 
> Review request for Extra Cmake Modules, Matthias Klumpp and Scarlett Clark.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> At the moment, we're validating it in build.kde.org, but I feel it will be easier for developers to test if we do so locally.
> This patch does it by seeing which `*.appdata.xml` files are being installed and validating them. This way we can keep it generic for all KDE projects.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake dd37e7f 
>   kde-modules/test_appstream.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128533/diff/
> 
> 
> Testing
> -------
> 
> Tested on some projects, locally.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160727/47f049ee/attachment-0001.html>