Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 18 13:08:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128427/
-----------------------------------------------------------

(Updated July 18, 2016, 1:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules, KDE Frameworks and Antonio Rojas.


Changes
-------

Submitted with commit 5bb92992317a6cf878c823cadac6dd0ccff969d6 by Aleix Pol to branch master.


Repository: extra-cmake-modules


Description
-------

In `KDEInstallDirs` we have some code to make sure that qmake is asked when the project shares the prefix with the installed Qt, to make sure that if something was changed in the distribution it would reflect on the projects.
Make sure PRI files are installed using the same reasoning.


Diffs
-----

  modules/ECMGeneratePriFile.cmake af4b877 

Diff: https://git.reviewboard.kde.org/r/128427/diff/


Testing
-------

The issue was reported by `arojas`, I haven't been able to reproduce myself.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160718/f606ea4a/attachment.html>


More information about the Kde-buildsystem mailing list