Review Request 128232: The default level for logging categories should be Info rather than Warning.

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 13 22:27:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128232/#review97364
-----------------------------------------------------------



+1

- Aleix Pol Gonzalez


On July 14, 2016, 12:22 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128232/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 12:22 a.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and David Edmundson.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> The whole point of Info is to be used by apps who want to print out some
> info for the user, not disabled by default.
> 
> Example use case: ksmserver could output the name of the autostart
> files it's starting, so user can check their own scripts are started,
> and associate any errors with the corresponding script.
> 
> In other words:
> Debug = debugging for the developer
> Info = debugging for the user :-)
> 
> This commit shows the benefit of having a central place for changing this
> (many category definitions do not use this macro though)
> 
> 
> Diffs
> -----
> 
>   modules/ECMQtDeclareLoggingCategory.cmake c125949a46c4b83544413f23d5e04b2d8ea2c4cf 
> 
> Diff: https://git.reviewboard.kde.org/r/128232/diff/
> 
> 
> Testing
> -------
> 
> The autotests still pass -- somewhat to my surprise ;-)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160713/a338657b/attachment.html>


More information about the Kde-buildsystem mailing list