Review Request 128352: Include KDEInstallDirs in ECMGeneratePriFile

[Antonio Rojas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128352/#review97304
-----------------------------------------------------------



Fixed properly in RR 128427

- Antonio Rojas


On Jul. 3, 2016, 12:17 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128352/
> -----------------------------------------------------------
> 
> (Updated Jul. 3, 2016, 12:17 p.m.)
> 
> 
> Review request for Extra Cmake Modules, Alex Merry and Aleix Pol Gonzalez.
> 
> 
> Bugs: 363348
>     http://bugs.kde.org/show_bug.cgi?id=363348
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> The cmake variable KDE_INSTALL_USE_QT_SYS_PATHS is used in ECMGeneratePriFile to decide the installation path for .pri files, but this variable is set in KDEInstallDirs since commit a2d184b
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/128352/diff/
> 
> 
> Testing
> -------
> 
> Compile kpeople (against system Qt) in the /usr prefix without setting -DKDE_INSTALL_USE_QT_SYS_PATHS=ON explicitely, the .pri files are installed in the correct path /usr/lib/qt/mkspecs/modules/ instead of the wrong /usr/mkspecs
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160712/ec716f20/attachment.html>