Review Request 126896: Make sure the prefix is looked-up
Andreas Cord-Landwehr
cordlandwehr at kde.org
Tue Jan 26 20:51:47 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126896/#review91629
-----------------------------------------------------------
Ship it!
Tested and works fine for me.
With regard to the CMake documentation, this change looks reasonable for me.
- Andreas Cord-Landwehr
On Jan. 26, 2016, 6:16 nachm., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126896/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 6:16 nachm.)
>
>
> Review request for Extra Cmake Modules and Andreas Cord-Landwehr.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> I've tried to compile ki18n against libintl-lite. This was required to be able to find it in our prefix.
>
> I can't but expect that other libraries would have a similar problem.
>
> The only reason why it used to work, is because all libraries we're including, provide `*Config.cmake` files, which don't respect this setting.
>
>
> Diffs
> -----
>
> toolchain/Android.cmake 81ded8f
>
> Diff: https://git.reviewboard.kde.org/r/126896/diff/
>
>
> Testing
> -------
>
> Now it fails somwhere else when building ki18n.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160126/2c4a657e/attachment.html>
More information about the Kde-buildsystem
mailing list