Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126711/#review91517
-----------------------------------------------------------



Sorry for the delay in responding to this.


tests/ECMAddAppIconTest/CMakeLists.txt (lines 16 - 18)
<https://git.reviewboard.kde.org/r/126711/#comment62530>

    This will fail on Linux, for example, where the macro essentially does nothing.
    
    Also, the message() command should be indented.


- Alex Merry


On Jan. 19, 2016, 10:05 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126711/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 10:05 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This makes it optional to list icons with ${CMAKE_CURRENT_SOURCE_DIR}/ prefix.
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddAppIcon.cmake 5233a5f 
>   tests/CMakeLists.txt afb825c 
>   tests/ECMAddAppIconTest/128-category-name.png PRE-CREATION 
>   tests/ECMAddAppIconTest/16-category-name.png PRE-CREATION 
>   tests/ECMAddAppIconTest/CMakeLists.txt PRE-CREATION 
>   tests/ECMAddAppIconTest/check_files.cmake.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126711/diff/
> 
> 
> Testing
> -------
> 
> Built KDevelop on Windows, the icon is here.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160124/9a9524bf/attachment.html>