Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

[Gleb Popov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126711/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 11:22 p.m.)


Review request for Extra Cmake Modules and Kevin Funk.


Changes
-------

Well, we are on the same boat here - if this thing gets broken, i'm the one who gets bitten by it. So here is my attempt on the test.


Repository: extra-cmake-modules


Description
-------

This makes it optional to list icons with ${CMAKE_CURRENT_SOURCE_DIR}/ prefix.


Diffs (updated)
-----

  modules/ECMAddAppIcon.cmake 5233a5f 
  tests/CMakeLists.txt afb825c 
  tests/ECMAddAppIconTest/128-category-name.png PRE-CREATION 
  tests/ECMAddAppIconTest/16-category-name.png PRE-CREATION 
  tests/ECMAddAppIconTest/CMakeLists.txt PRE-CREATION 
  tests/ECMAddAppIconTest/check_files.cmake.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126711/diff/


Testing
-------

Built KDevelop on Windows, the icon is here.


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160113/39754b43/attachment.html>