Review Request 126648: Allow to disable KArchive for internal usage
David Faure
faure at kde.org
Thu Jan 7 08:33:04 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126648/#review90735
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Jan. 6, 2016, 9:33 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126648/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 9:33 p.m.)
>
>
> Review request for Build System, KDE Frameworks, Alex Merry, and David Faure.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> Most of the code was already prepared to compile without the KArchive dependency (including the MEINPROC_NO_KARCHIVE flag).
> This mode should be only enabled on KDE infrastructure, as the compressed cache (the only added feature coming from KArchive) is not used by the generator of the documentation website.
> A warning is printed when the mode is enabled.
> The saveToCache function is preserved, even if without code, to minimize the changes required.
>
>
> Diffs
> -----
>
> CMakeLists.txt 2ec3027
> src/CMakeLists.txt 136fbfb
> src/xslt_kde.cpp 7069a28
>
> Diff: https://git.reviewboard.kde.org/r/126648/diff/
>
>
> Testing
> -------
>
> Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160107/e8b7a044/attachment.html>
More information about the Kde-buildsystem
mailing list