Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix
David Faure
faure at kde.org
Sat Feb 27 13:41:26 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/#review92830
-----------------------------------------------------------
Nicolás: if the prefixes are different, then this patch doesn't change anything (since it compares the prefixes). So it makes sense to me.
Adopt the Qt plugins dir when installing into the same prefix as Qt, keep default paths otherwise.
+1
- David Faure
On Feb. 24, 2016, 5:09 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127169/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 5:09 p.m.)
>
>
> Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca Cintora.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Make Qt and ECM-based projects use the same directory sctructure (i.e. where plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that might be controlled but usually won't.
>
> In the end, otherwise, people need to keep adapting their systems with environment variables anyway. All distros end up setting always this setting as ON, as well as brave developers who don't have separate prefixes for Qt and KDE.
>
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake ebd48fa
>
> Diff: https://git.reviewboard.kde.org/r/127169/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160227/158b3351/attachment.html>
More information about the Kde-buildsystem
mailing list