Review Request 129708: C project also need Clang Sanitizer

Leslie Zhai xiangzhai83 at gmail.com
Thu Dec 29 02:46:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129708/
-----------------------------------------------------------

(Updated 十二月 29, 2016, 10:46 a.m.)


Review request for Extra Cmake Modules and Alex Merry.


Changes
-------

Hi Albert,

Sorry for that, I often use 

```
-DCMAKE_C_COMPILER=clang
-DCMAKE_CXX_COMPILER=clang++
```

so I forgot to test GNU compiler! and I added the check

```
if(CMAKE_C_COMPILER_ID MATCHES "Clang")
```
and test kcoreaddons and kjs, it is OK for building with GNU compiler! please review it for me, thanks a lot!

Regards,
Leslie Zhai


Bugs: 374195
    http://bugs.kde.org/show_bug.cgi?id=374195


Repository: extra-cmake-modules


Description
-------

So I just added

```
set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${XSAN_COMPILE_FLAGS}" )
```

for C project to use Clang Sanitizer.


Diffs (updated)
-----

  modules/ECMEnableSanitizers.cmake 9c8a4de 

Diff: https://git.reviewboard.kde.org/r/129708/diff/


Testing
-------

testcase for Clang Static Analyzer, and also for Clang Sanitizer https://github.com/LLVM-China/clang-analyzer.github.io/tree/master/tests


Thanks,

Leslie Zhai

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161229/9106bf1d/attachment.html>


More information about the Kde-buildsystem mailing list