Review Request 127600: Add support for imagemagick convert tool for Windows app icon generation

Thu Apr 7 11:01:43 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127600/
-----------------------------------------------------------

Review request for Extra Cmake Modules.

Repository: extra-cmake-modules

Description
-------

This is mainly useful when cross compiling for Windows. On debian there is no png2ico packaged, but convert is easily available through packages.
Another advantage of convert is that it can also handle 256px png's this is the reason I've preferred it over png2ico if both would be available.

Diffs
-----

  find-modules/FindConvert.cmake PRE-CREATION 
  modules/ECMAddAppIcon.cmake ca64314 

Diff: https://git.reviewboard.kde.org/r/127600/diff/

Testing
-------

Built kleopatra for Windows on Debian GNU/Linux with it and checked that the icon is correctly embedded.

Thanks,

Andre Heinecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160407/f4892709/attachment.html>