Review Request 127432: ecm_qt_declare_logging_category: improve error message when using without including

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127432/
-----------------------------------------------------------

(Updated April 3, 2016, 8:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules and Stephen Kelly.


Changes
-------

Submitted with commit f7c1e8d57f84d0883a2a7683fd59ecc990a03de1 by David Faure to branch master.


Repository: extra-cmake-modules


Description
-------

If one subdir in the project includes this file, all others can use the function
but they don't see the value of the variable, which leads to a strange error

CMake Error at ECM/modules/ECMQtDeclareLoggingCategory.cmake:114 (configure_file):
  configure_file input location <srcdir> is a directory but a file was expected.

Happened in KIO, with kio/gui doing include+function call, and then adding
function call in kio/widgets.


Diffs
-----

  modules/ECMQtDeclareLoggingCategory.cmake 3f7bb79a7f4d98c1480f87b1fffc252f4e159add 

Diff: https://git.reviewboard.kde.org/r/127432/diff/


Testing
-------

As described in above. Got the better error message after the fix.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160403/06985367/attachment.html>