Review Request 125267: Fix build of HelloKAndroid with cmake 3.3.1 and Qt5.5

[Matthieu Gallien]

> On sep. 17, 2015, 12:42 après-midi, Aleix Pol Gonzalez wrote:
> > It will be superseeded by https://git.reviewboard.kde.org/r/125084/ which is waiting for review.
> > 
> > Note that the hook can be called multiple times, it should be ensured that it only calls the generation function once, after the target construction

I agree that the hook can be called multiple times, but as it seems there is another review pending, I can just drop it from the review request and keep the fix for the qml directory. Is it OK for you ?


- Matthieu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125267/#review85555
-----------------------------------------------------------


On sep. 17, 2015, 7:10 matin, Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125267/
> -----------------------------------------------------------
> 
> (Updated sep. 17, 2015, 7:10 matin)
> 
> 
> Review request for Extra Cmake Modules, Aleix Pol Gonzalez, Andreas Cord-Landwehr, and Friedrich W. H. Kossebau.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Fix build of HelloKAndroid with cmake 3.3.1 and Qt5.5
> 
> 
> Diffs
> -----
> 
>   toolchain/deployment-file.json.in 8534cd2 
>   toolchain/Android.cmake 9b10474 
> 
> Diff: https://git.reviewboard.kde.org/r/125267/diff/
> 
> 
> Testing
> -------
> 
> Without my patch, I am unable to build against cmake 3.3.1 and Qt5.5.
> 
> 
> Thanks,
> 
> Matthieu Gallien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150917/ffd4022b/attachment.html>