Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

Raphael Kubo da Costa rakuco at FreeBSD.org
Tue Sep 15 08:59:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125236/
-----------------------------------------------------------

Review request for Build System and kdelibs.


Repository: kdelibs


Description
-------

Backport upstream CMake commit de30173d ("Remove C compiler requirement
from FindQt4.cmake") from 2011 so that we check for symbols such as the
Q_WS_* ones with a C++ compiler instead of a C one.


Diffs
-----

  cmake/modules/FindQt4.cmake e439a72f82c51758830b057b368407e11a6a541e 

Diff: https://git.reviewboard.kde.org/r/125236/diff/


Testing
-------

Adding something C++-specific to qglobal.h (e.g. `#include <ciso646>`)
works and the right flags are still detected.


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150915/9093565b/attachment.html>


More information about the Kde-buildsystem mailing list