Review Request 125163: Disable X11,XCB etc. detection on OS X

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125163/#review85291
-----------------------------------------------------------



kde-modules/KDECMakeSettings.cmake (line 51)
<https://git.reviewboard.kde.org/r/125163/#comment58949>

    could you add the value you need to set to this, as in
    
        by setting ``APPLE_FORCE_X11`` to ``ON``.



kde-modules/KDECMakeSettings.cmake (line 55)
<https://git.reviewboard.kde.org/r/125163/#comment58950>

    Can you add when the option/behaviour change was? You probably want to make this a list, as in:
    
        # - Uninstall target functionality since 1.7.0
        # - ``APPLE_FORCE_X11`` option since 5.14.0 (detecting X11 was previously the default behaviour)


- Alex Merry


On Sept. 12, 2015, 8:44 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125163/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 8:44 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Disable X11,XCB etc. detection on OS X
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake 0c997931abee8673ccecc66d122108c6f72bf9b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125163/diff/
> 
> 
> Testing
> -------
> 
> KCrash build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150912/221534a7/attachment-0001.html>