Review Request 125163: Disable X11,XCB etc. detection on OS X

[Alex Merry]

> On Sept. 12, 2015, 11:08 a.m., Alex Merry wrote:
> > The new option needs documenting at the top of the file.
> > 
> > I'd like to have other Mac users / porters providing some input, if possible. In what circumstances would it be useful to use the new option? Is this going to affect homebrew or macports (ie: do they provide packages that they will have to set this option for, and is someone planning to inform them of this)?
> 
> Samuel Gaist wrote:
>     The idea I had behind that option was to let the users/porters decide whether or not they want to build against X11 on OS X. It might not make sense at first but since macports at least provides Xorg.
>     
>     I didn't tought about informing them about it but I will gladly do it if the option stays.
>     
>     Note that I'm not against removing it at all, it really is just to simplify life of people who would need to build against X11 on OS X.

It's not the option I'm concerned about as such, it's the fact that this patch changes the default behaviour. So anyone wanting to build against X11 on OS X would now have to set this option, whereas before they just had to have Xorg installed and findable by CMake.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125163/#review85248
-----------------------------------------------------------


On Sept. 12, 2015, 8:44 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125163/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 8:44 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Disable X11,XCB etc. detection on OS X
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake 0c997931abee8673ccecc66d122108c6f72bf9b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125163/diff/
> 
> 
> Testing
> -------
> 
> KCrash build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150912/31c1dfdc/attachment.html>