Review Request 125183: Add definition ANDROID as needed in qsystemdetection.h.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125183/#review85233
-----------------------------------------------------------

Ship it!


Correct, I was a bit hesitant to add something like this but it's needed anyway.

I sent a patch to Qt to figure this out, although it will land too late for us anyway.
https://codereview.qt-project.org/#/c/125618/

- Aleix Pol Gonzalez


On Sept. 12, 2015, 10:18 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125183/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 10:18 a.m.)
> 
> 
> Review request for Extra Cmake Modules, Aleix Pol Gonzalez and Dennis Nienhüser.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> QtCore/qsystemdetection.h sets the define Q_OS_ANDROID based on having
> ANDROID defined. Hence, adding the ANDROID define allows applications to
> use the Q_OS_ANDROID for ifdef'ing.
> 
> 
> Diffs
> -----
> 
>   toolchain/Android.cmake 0144f379b1f5db57aca2f9cf4e893d9c43205a60 
> 
> Diff: https://git.reviewboard.kde.org/r/125183/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150912/8bc92bd2/attachment.html>