Review Request 125031: Disable -Wno-gnu-zero-variadic-macro-arguments when using clang
Alex Merry
alex.merry at kde.org
Tue Sep 8 20:44:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125031/#review85023
-----------------------------------------------------------
Ship it!
Actually, can you make one small change?
kde-modules/KDEFrameworkCompilerSettings.cmake (line 51)
<https://git.reviewboard.kde.org/r/125031/#comment58810>
Add a comment noting why we're disabling the warning.
- Alex Merry
On Sept. 2, 2015, 4:27 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125031/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 4:27 p.m.)
>
>
> Review request for Extra Cmake Modules.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> This warning is emitted for every qCDebug() call and is not useful.
>
>
> Diffs
> -----
>
> kde-modules/KDEFrameworkCompilerSettings.cmake 84de77abd0e8dbc2552b772b857e92dc8b135549
>
> Diff: https://git.reviewboard.kde.org/r/125031/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150908/c7e652ff/attachment.html>
More information about the Kde-buildsystem
mailing list