Review Request 123726: Make sure we load translations on the main thread.

Alex Merry alex.merry at kde.org
Wed Oct 14 19:15:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123726/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 7:15 p.m.)


Review request for Extra Cmake Modules, Aurélien Gâteau and Chusslove Illich.


Changes
-------

Make suggested changes, add tests.


Bugs: 346188
    http://bugs.kde.org/show_bug.cgi?id=346188


Repository: extra-cmake-modules


Description
-------

BUG: 346188


Diffs (updated)
-----

  modules/ECMPoQmTools.cmake 12bcf6b67c57dd456f078820f86c1e8365cb7c06 
  modules/ECMQmLoader.cpp.in bc01bf98f0caa0aedf6b6175ef6c9f7757afdf1b 
  tests/CMakeLists.txt 8a75ae61d9c2ce2eeb78e0a4c308d0d0c5fff5a5 
  tests/ECMPoQmToolsTest/CMakeLists.txt 15351d2f710f9bd07a38d3b1ad9b15e24bc64a61 
  tests/ECMPoQmToolsTest/check_conf.cmake.in PRE-CREATION 
  tests/ECMPoQmToolsTest/check_tree.cmake.in 9f4f7c0d19f286647ad1c9c99362bd921ff01cba 
  tests/ECMPoQmToolsTest/main.cpp PRE-CREATION 
  tests/ECMPoQmToolsTest/tr_test-po/en/catalog.po PRE-CREATION 
  tests/ECMPoQmToolsTest/tr_test-po/en_GB/catalog.po PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123726/diff/


Testing (updated)
-------

Added test for basic functionality. Threaded stuff not tested yet (ie: the test doesn't check that this patch fixes things, but it does check that it doesn't break the already-working case).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151014/b0113cea/attachment.html>


More information about the Kde-buildsystem mailing list