Review Request 125561: Align FindGettext with CMP002 policy

[Hrvoje Senjan]

> On Oct. 10, 2015, 11:23 a.m., Albert Astals Cid wrote:
> > This is so much cleaner and easier to understand, what would be a way to test this, i.e. which tarball do i use that has the problem this is fixing?
> 
> Albert Astals Cid wrote:
>     i.e. you mention skanlite, but which tarball of it exactly?
> 
> Yuri Chornoivan wrote:
>     It can be LabPlot as well:
>     
>     http://download.kde.org/stable/labplot/2.1.0/labplot-2.1.0-RC1.tar.xz
> 
> Alexander Semke wrote:
>     http://download.kde.org/stable/labplot/2.1.0/labplot-2.1.0-RC2.tar.xz.mirrorlist

You can try with e.g. kraft 0.58, kde-gtk-config 2.2.1, skanlite 1.1...


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125561/#review86609
-----------------------------------------------------------


On Oct. 10, 2015, 1:42 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125561/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 1:42 a.m.)
> 
> 
> Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Otherwise some apps fail to build with kdelibs >= 4.14.11:
> ```
> CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET):
>   add_custom_target cannot create target "pofiles" because another target
>   with the same name already exists.  The existing target is a custom target
>   created in source directory
>   "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be".  See documentation for
>   policy CMP0002 for more details.
> Call Stack (most recent call first):
>   po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
> ```
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindGettext.cmake 91e88f7 
> 
> Diff: https://git.reviewboard.kde.org/r/125561/diff/
> 
> 
> Testing
> -------
> 
> Skanlite now builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151010/b9782697/attachment.html>