Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125561/#review86518
-----------------------------------------------------------


Looks good to me, but I can't quite follow it all myself. Someone else should give the ship it. If it fixes it so setting the CMake policy 0002 to OLD isn't needed anymore that's good.

- Jeremy Whiting


On Oct. 8, 2015, 11:50 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125561/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 11:50 a.m.)
> 
> 
> Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Otherwise some apps fail to build with kdelibs >= 4.14.11:
> ```
> CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET):
>   add_custom_target cannot create target "pofiles" because another target
>   with the same name already exists.  The existing target is a custom target
>   created in source directory
>   "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be".  See documentation for
>   policy CMP0002 for more details.
> Call Stack (most recent call first):
>   po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
> ```
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindGettext.cmake 91e88f7 
> 
> Diff: https://git.reviewboard.kde.org/r/125561/diff/
> 
> 
> Testing
> -------
> 
> Skanlite now builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151008/a73b45fe/attachment.html>