Review Request 123726: Make sure we load translations on the main thread.

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123726/#review86403
-----------------------------------------------------------


As for test, create a fake application to use this and check whether the expected string loaded?


modules/ECMQmLoader.cpp.in (line 51)
<https://git.reviewboard.kde.org/r/123726/#comment59524>

    This constructor is not defined and not used anywhere.



modules/ECMQmLoader.cpp.in (line 54)
<https://git.reviewboard.kde.org/r/123726/#comment59525>

    loadSlot, maybe?



modules/ECMQmLoader.cpp.in (line 73)
<https://git.reviewboard.kde.org/r/123726/#comment59526>

    second argument of invokeMethod should be the string of function name, not slot.


- Xuetian Weng


On May 11, 2015, 10:42 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123726/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 10:42 p.m.)
> 
> 
> Review request for Extra Cmake Modules, Aurélien Gâteau and Chusslove Illich.
> 
> 
> Bugs: 346188
>     http://bugs.kde.org/show_bug.cgi?id=346188
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> BUG: 346188
> 
> 
> Diffs
> -----
> 
>   modules/ECMQmLoader.cpp.in bc01bf98f0caa0aedf6b6175ef6c9f7757afdf1b 
> 
> Diff: https://git.reviewboard.kde.org/r/123726/diff/
> 
> 
> Testing
> -------
> 
> None, I don't have a good way of testing this. If anyone has a good testing recipe, that would help me. Even better, if someone is willing to write a unit test...
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151006/93ed2b5c/attachment.html>