Review Request 125192: Update GTK icon cache when installing icons.

David Faure faure at kde.org
Sat Oct 3 08:23:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125192/#review86280
-----------------------------------------------------------

Ship it!


Right, sorry for delaying the "ship it" on this one. The discussion derailed into whether Qt should or shouldn't do a recursive mtime check, but this patch in itself is good to go, of course.

- David Faure


On Sept. 12, 2015, 12:23 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125192/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 12:23 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Olivier Goffart.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Despite the name, Qt is also using this, and it considerably speeds up
> icon lookup.
> 
> 
> Diffs
> -----
> 
>   modules/ECMInstallIcons.cmake 79dc5150e8a966db2a9fdd39cbd5ce8c2f842e18 
> 
> Diff: https://git.reviewboard.kde.org/r/125192/diff/
> 
> 
> Testing
> -------
> 
> Built and installed kdepim, cache files are generated in the expected places.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151003/d6806241/attachment.html>


More information about the Kde-buildsystem mailing list