Review Request 126000: Make sure we load translations on the main thread.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126000/#review88733
-----------------------------------------------------------



modules/ECMQmLoader.cpp.in (line 73)
<https://git.reviewboard.kde.org/r/126000/#comment60838>

    "correct" is obvious but not precise. Should say "main" instead.



modules/ECMQmLoader.cpp.in (line 76)
<https://git.reviewboard.kde.org/r/126000/#comment60841>

    You could just use invokeMethod + QueuedConnection, no?
    
    Then the whole prose about QEvent types can be removed ;)



tests/ECMPoQmToolsTest/tr_thread_test.cpp (line 27)
<https://git.reviewboard.kde.org/r/126000/#comment60839>

    you can easily assert that, like Q_ASSERT(QThread::currentThread() == qApp->thread());



tests/ECMPoQmToolsTest/tr_thread_test.cpp (line 32)
<https://git.reviewboard.kde.org/r/126000/#comment60840>

    qPrintable(m_lib->errorString()) is slightly shorter.


- David Faure


On Nov. 22, 2015, 12:46 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126000/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2015, 12:46 p.m.)
> 
> 
> Review request for Extra Cmake Modules and David Faure.
> 
> 
> Bugs: 346188
>     http://bugs.kde.org/show_bug.cgi?id=346188
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Because the old implementation (accidentally) worked when you put the
> ecm_create_qm_loader call in a different CMakeLists.txt file to the
> target the file was added to, some projects did this.
> 
> This won't work with build-time-generated files, though, like moc files.
> So we (ab)use QTimer events to make the loading happen on the main
> thread.
> 
> BUG: 346188
> 
> 
> Diffs
> -----
> 
>   modules/ECMPoQmTools.cmake 0af5b12fdd662c07792e6084b7279b98dc99cf97 
>   modules/ECMQmLoader.cpp.in 423d1c932ddcf3d98c94d2f67e73355129357768 
>   tests/ECMPoQmToolsTest/CMakeLists.txt 73d2b4271d646107ce02bb2da71fbe0d11f80fc8 
>   tests/ECMPoQmToolsTest/check.cmake.in 5329b78d06bebb9aa14595201f45ac868afd8e81 
>   tests/ECMPoQmToolsTest/check_conf.cmake.in 7bd11c36e2830e868c83f455e4b2809b72fcb3ce 
>   tests/ECMPoQmToolsTest/tr_thread_test.cpp PRE-CREATION 
>   tests/ECMPoQmToolsTest/tr_thread_test_module.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126000/diff/
> 
> 
> Testing
> -------
> 
> Extended unit tests, which pass. Built the world (all the default frameworks stuff) with kdesrc-build.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151123/804d7dd9/attachment.html>