Review Request 125935: Do not find XCB's XINPUT library by default.

Alex Merry alex.merry at kde.org
Tue Nov 17 21:23:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125935/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 9:23 p.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules and Martin Gräßlin.


Changes
-------

Submitted with commit 7d6915b482820e53c46b3a68ac27d2ef8485a248 by Alex Merry to branch master.


Repository: extra-cmake-modules


Description
-------

The XINPUT library is unlikely to be available on many systems,
including a lot of Linux distributions. This will warn developers in
advance by (a) not searching for XINPUT unless it was explicitly
requested, and (b) printing a warning if they do request it.


Diffs
-----

  find-modules/FindXCB.cmake b2a800f73058382ee84f7d93132a96f8852b4aa7 
  modules/ECMFindModuleHelpers.cmake 63cccb933334e0c392159abe161419d3f48b21f3 

Diff: https://git.reviewboard.kde.org/r/125935/diff/


Testing
-------

wacomtablet's kf5-port branch still configures, but with a warning. kwin configures without a warning. Modified kwindowsystem to call find_package(XCB), and that also configures without a warning.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151117/55ec47ca/attachment.html>


More information about the Kde-buildsystem mailing list