Review Request 126090: Make it easy to enable clazy on our build directories

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126090/#review88442
-----------------------------------------------------------


Creating a module for these four lines seems a bit overkill. Are we planning to have a module for every Clang plugin?

TBH, I'd just put the code straight into KDECompilerSettings. If you think the clang module loading arguments are complex enough to warrant abstracting away, I'd prefer a more general function for loading clang modules.


modules/ECMEnableClazyOption.cmake (line 5)
<https://git.reviewboard.kde.org/r/126090/#comment60614>

    I'd reword this as "Allows users to easily enable clazy warnings for a project.".



modules/ECMEnableClazyOption.cmake (line 13)
<https://git.reviewboard.kde.org/r/126090/#comment60613>

    This is the wrong version. It should be 5.17.0 by now.


Needs a URL - the documentation makes no sense if you don't already know what clazy is.

- Alex Merry


On Nov. 16, 2015, 5:11 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126090/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 5:11 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Sergio Martins.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Introduces a variable that will enable the usage of clazy iif clang is the compiler.
> 
> 
> Diffs
> -----
> 
>   modules/ECMEnableClazyOption.cmake PRE-CREATION 
>   kde-modules/KDECompilerSettings.cmake 73d7782 
> 
> Diff: https://git.reviewboard.kde.org/r/126090/diff/
> 
> 
> Testing
> -------
> 
> I built a couple of projects with it already.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151116/53b59d4c/attachment.html>