Review Request 126075: Overhaul the ECM build system.

Alex Merry alex.merry at kde.org
Sun Nov 15 16:17:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126075/
-----------------------------------------------------------

(Updated Nov. 15, 2015, 4:17 p.m.)


Review request for Extra Cmake Modules and David Faure.


Changes
-------

Add example output.


Repository: extra-cmake-modules


Description
-------

It should now be easier to read, and more featureful. Among other
tweaks, we now print a summary of dependencies and build options, and
the documentation is generated with more sensible breadcrumbs and
builds properly with Sphinx 1.3.


Diffs
-----

  .gitignore PRE-CREATION 
  CMakeLists.txt c1abd6c7be925dcebd5e9962fa05ae143abdf76b 
  ECMConfig.cmake.in b163e3ae6e7b0f0f4d4620700a35ac501c6f94f8 
  cmake/FindQCollectionGenerator.cmake PRE-CREATION 
  cmake/FindSphinx.cmake PRE-CREATION 
  docs/CMakeLists.txt f17400f8e96886c8beba45b9c9322960be20ba43 
  docs/sphinx/conf.py.in 792c87ca1386ef3f7d8d58d6546c81c11d920e2f 
  docs/sphinx/ecm.py  
  docs/sphinx/static/ecm.css 2a326d47dda1d74f20aa6d7a65e27ffae26f08c3 
  tests/CMakeLists.txt 9e6de12f2b82766aa0ab592fb4dff61f09b289e1 
  tests/ECMGenerateHeadersTest/CMakeLists.txt 9f407cb09064b9a278a74e183a7c2136337729fc 
  tests/ECMGeneratePkgConfigFile/CMakeLists.txt f3bc267d9ed14881807deebaf8fd11fe6ae6402d 

Diff: https://git.reviewboard.kde.org/r/126075/diff/


Testing (updated)
-------

Configured, built and installed with CMake 2.8.12.2 and with CMake 3.3.

Tested with various combinations of sphinx-build 1.3.1 (python2 and python3 versions) and qcollectiongenerator (Qt4 and Qt5 versions) installed or not.

All seem to work sensibly.

Generated HTML documentation checked by eye.

sphinx-build 1.2.2 (used by api.kde.org) *not* tested.

Example output:

    -- Found Sphinx: /usr/bin/sphinx-build (found suitable version "1.3.1", minimum required is "1.2") 
    -- Found QCollectionGenerator: /usr/bin/qcollectiongenerator (found version "1.0") 
    -- The C compiler identification is GNU 5.2.0
    -- Check for working C compiler: /usr/bin/cc
    -- Check for working C compiler: /usr/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- 
    -- The following features have been enabled:
    
     * BUILD_HTML_DOCS , Generate HTML documentation for installed modules.
     * BUILD_MAN_DOCS , Generate man page documentation for installed modules.
     * BUILD_QTHELP_DOCS , Generate QtHelp documentation for installed modules.
     * BUILD_TESTING , Build automated tests.
    
    -- The following OPTIONAL packages have been found:
    
     * Sphinx (required version >= 1.2) , Tool to generate documentation. , <http://sphinx-doc.org/>
       Required to build documentation for Extra CMake Modules.
     * QCollectionGenerator , Qt help collection generator. , <http://www.qt.io/>
       Required to build Extra CMake Modules documentation in Qt Help format.
     * Qt5LinguistTools , Qt5 linguist tools. , <http://www.qt.io/>
       Required to run tests for the ECMPoQmTools module.
     * Qt5Core , Qt5 core library. , <http://www.qt.io/>
       Required to run tests for the ECMQtDeclareLoggingCategory module, and for some tests of the KDEInstallDirs module.
    
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/kde-devel/src/extra-cmake-modules/build


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151115/b30872a0/attachment.html>


More information about the Kde-buildsystem mailing list