Review Request 125999: Fix multiple calls to ecm_create_qm_loader.

[Alex Merry]

> On Nov. 14, 2015, 4:16 p.m., David Faure wrote:
> > tests/ECMPoQmToolsTest/CMakeLists.txt, line 93
> > <https://git.reviewboard.kde.org/r/125999/diff/1/?file=415758#file415758line93>
> >
> >     I'm curious, does "PRIVATE" really make any difference for an executable?

Not in practice (remember the weird situations where CMP0063 matters? I expect it affects those cases), but it's more consistent with how commands like target_compile_definitions have to be called.


> On Nov. 14, 2015, 4:16 p.m., David Faure wrote:
> > tests/ECMPoQmToolsTest/CMakeLists.txt, line 97
> > <https://git.reviewboard.kde.org/r/125999/diff/1/?file=415758#file415758line97>
> >
> >     I don't really understand this sentence. "to target" ?

Ah, I'll clarify that - I mean "to where the target is defined".


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125999/#review88356
-----------------------------------------------------------


On Nov. 9, 2015, 3:40 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125999/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 3:40 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Multiple ecm_create_qm_loader() with different catalog names would
> overwrite each other's generated files, causing the wrong catalog to be
> loaded at runtime for some targets.
> 
> This puts the catalog name into the generated filename. Since the
> catalog name is the only difference between the generated files, this is
> sufficient to fix the runtime behaviour.
> 
> 
> Diffs
> -----
> 
>   modules/ECMPoQmTools.cmake 12bcf6b67c57dd456f078820f86c1e8365cb7c06 
>   tests/ECMPoQmToolsTest/CMakeLists.txt 76d801411b87987ac05de8dd99a0f37266ef6909 
>   tests/ECMPoQmToolsTest/check.cmake.in ab434d2e425ff57f323a196acc60e0e52c0abb10 
>   tests/ECMPoQmToolsTest/check_conf.cmake.in 9ab02e72c4f5aa740c04116e824a54c61fe8bda8 
>   tests/ECMPoQmToolsTest/tr_test-po/de/catalog2.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/tr_test-po/en/catalog2.po PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125999/diff/
> 
> 
> Testing
> -------
> 
> Extended unit tests, which pass. Built frameworks and ~100 frameworks-based KDE projects.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151114/239ef913/attachment.html>