Review Request 126000: Make sure we load translations on the main thread.

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126000/
-----------------------------------------------------------

(Updated Nov. 10, 2015, 9:11 p.m.)


Review request for Extra Cmake Modules.


Changes
-------

Add version notes to docs, and more testing.


Bugs: 346188
    http://bugs.kde.org/show_bug.cgi?id=346188


Repository: extra-cmake-modules


Description
-------

Because the old implementation (accidentally) worked when you put the
ecm_create_qm_loader call in a different CMakeLists.txt file to the
target the file was added to, some projects did this.

This won't work with build-time-generated files, though, like moc files.
So this modifies the API of ecm_create_qm_loader (adding a keyword for
the catalog argument), and essentially behaves as before (without the
multithreading fix) if the new interface is not used.

BUG: 346188


Diffs (updated)
-----

  modules/ECMPoQmTools.cmake 12bcf6b67c57dd456f078820f86c1e8365cb7c06 
  modules/ECMQmLoader.cpp.in 423d1c932ddcf3d98c94d2f67e73355129357768 
  tests/ECMPoQmToolsTest/CMakeLists.txt 76d801411b87987ac05de8dd99a0f37266ef6909 
  tests/ECMPoQmToolsTest/check.cmake.in ab434d2e425ff57f323a196acc60e0e52c0abb10 
  tests/ECMPoQmToolsTest/check_conf.cmake.in 9ab02e72c4f5aa740c04116e824a54c61fe8bda8 
  tests/ECMPoQmToolsTest/tr_thread_test.cpp PRE-CREATION 
  tests/ECMPoQmToolsTest/tr_thread_test_module.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126000/diff/


Testing (updated)
-------

Extended unit tests, which pass. Built the world (all the default frameworks stuff) with kdesrc-build.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151110/2b600820/attachment.html>