Review Request 125931: Warn instead of error if ecm_install_icons finds no icons.

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125931/
-----------------------------------------------------------

(Updated Nov. 4, 2015, 9:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules.


Changes
-------

Submitted with commit 21629f651a6a5d9d977be03fd9f98417c4fa27ae by Alex Merry to branch master.


Repository: extra-cmake-modules


Description
-------

The V1 syntax of ecm_install_icons searched for icons by globbing files
with a particular naming pattern. If there were no such icons, this used
to do nothing, but silently. Commit fb7b8eea7d accidentally made this an
error. More sensible would be to make it a warning.

BUG: 354610


Diffs
-----

  modules/ECMInstallIcons.cmake 8db486e7ab0db3d9f43d09a4b8b22a97a07b3bae 
  tests/ECMInstallIconsTest/CMakeLists.txt 738cba916a2798d5ef63300f0db418e2ee9fb3be 
  tests/ECMInstallIconsTest/v1-syntax-no-icons/CMakeLists.txt PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125931/diff/


Testing
-------

Extended unit test, which passes, and ksirk now successfully configures.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151104/dc4c4def/attachment.html>