Review Request 125935: Do not find XCB's XINPUT library by default.

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125935/#review87982
-----------------------------------------------------------


Thanks. The approach looks sensible to me. I hope the warnings get read, though.

- Martin Gräßlin


On Nov. 3, 2015, 7:39 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125935/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 7:39 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> The XINPUT library is unlikely to be available on many systems,
> including a lot of Linux distributions. This will warn developers in
> advance by (a) not searching for XINPUT unless it was explicitly
> requested, and (b) printing a warning if they do request it.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindXCB.cmake b2a800f73058382ee84f7d93132a96f8852b4aa7 
>   modules/ECMFindModuleHelpers.cmake 63cccb933334e0c392159abe161419d3f48b21f3 
> 
> Diff: https://git.reviewboard.kde.org/r/125935/diff/
> 
> 
> Testing
> -------
> 
> wacomtablet's kf5-port branch still configures, but with a warning. kwin configures without a warning. Modified kwindowsystem to call find_package(XCB), and that also configures without a warning.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151104/77021feb/attachment-0001.html>