Review Request 123726: Make sure we load translations on the main thread.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123726/#review87899
-----------------------------------------------------------

Ship it!


The threading code looks OK. Slots in a QThread subclass are indeed very unintuitive, so I recommend never doing that, but for the benefit of keeping the test simple and since you documented it, I'll let this one pass ;-)


modules/ECMQmLoader.cpp.in (line 46)
<https://git.reviewboard.kde.org/r/123726/#comment60303>

    maybe in an anonymous namespace, to avoid clashes if this generated code happens twice in the same binary/library? (or in case hidden-visibility is disabled)


- David Faure


On Oct. 14, 2015, 9:38 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123726/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 9:38 p.m.)
> 
> 
> Review request for Extra Cmake Modules, Aurélien Gâteau and Chusslove Illich.
> 
> 
> Bugs: 346188
>     http://bugs.kde.org/show_bug.cgi?id=346188
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> BUG: 346188
> 
> 
> Diffs
> -----
> 
>   modules/ECMPoQmTools.cmake 12bcf6b67c57dd456f078820f86c1e8365cb7c06 
>   modules/ECMQmLoader.cpp.in bc01bf98f0caa0aedf6b6175ef6c9f7757afdf1b 
>   tests/CMakeLists.txt 8a75ae61d9c2ce2eeb78e0a4c308d0d0c5fff5a5 
>   tests/ECMPoQmToolsTest/CMakeLists.txt 15351d2f710f9bd07a38d3b1ad9b15e24bc64a61 
>   tests/ECMPoQmToolsTest/check_conf.cmake.in PRE-CREATION 
>   tests/ECMPoQmToolsTest/check_tree.cmake.in 9f4f7c0d19f286647ad1c9c99362bd921ff01cba 
>   tests/ECMPoQmToolsTest/tr_test-po/en/catalog.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/tr_test-po/en_GB/catalog.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/tr_test.cpp PRE-CREATION 
>   tests/ECMPoQmToolsTest/tr_thread_test.cpp PRE-CREATION 
>   tests/ECMPoQmToolsTest/tr_thread_test_module.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123726/diff/
> 
> 
> Testing
> -------
> 
> Added tests for basic functionality and for loading a module on a thread. Both pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151103/01498a70/attachment.html>