Review Request 123841: Add arguments to ecm_add_tests for listing added tests.

Alex Merry alex.merry at kde.org
Mon May 18 19:05:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123841/
-----------------------------------------------------------

(Updated May 18, 2015, 7:05 p.m.)


Review request for Extra Cmake Modules.


Changes
-------

Fix typo, and another change suggested by Stephen.


Bugs: 345797
    http://bugs.kde.org/show_bug.cgi?id=345797


Repository: extra-cmake-modules


Description
-------

Rework ECMAddTests documentation to emphasis ecm_add_tests().

ecm_add_test is the less useful (and less used) version of the functions
(because you really might as well just use add_executable() and
add_test() manually in that case).


Add arguments to ecm_add_tests for listing added tests.

This makes it convenient to make further modifications to the tests,
such as setting properties on either the tests or the targets.

CHANGELOG: New arguments for ecm_add_tests().
BUG: 345797


Diffs (updated)
-----

  modules/ECMAddTests.cmake bdb606919b49d5d8400a7d49935c0f569d279076 
  tests/ECMAddTests/multi_tests/CMakeLists.txt ca43477359fbfb8d41b1bb2ad08aeb3e75c99a1c 
  tests/test_helpers.cmake 73be343e5a9fe603e8c4ba042c833d3f9360b6df 

Diff: https://git.reviewboard.kde.org/r/123841/diff/


Testing
-------

Added unit tests, which pass.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150518/f0304631/attachment.html>


More information about the Kde-buildsystem mailing list