Review Request 123841: Add arguments to ecm_add_tests for listing added tests.

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123841/#review80596
-----------------------------------------------------------



modules/ECMAddTests.cmake (line 57)
<https://git.reviewboard.kde.org/r/123841/#comment55257>

    Stuck shift key :)



modules/ECMAddTests.cmake (line 92)
<https://git.reviewboard.kde.org/r/123841/#comment55259>

    Why is this quoted?



modules/ECMAddTests.cmake (line 102)
<https://git.reviewboard.kde.org/r/123841/#comment55260>

    This bundling is also not ideal. Consider adding a 
    
        ecm_targets_link_libraries(tgt1 [tgt2 ...] 
            PRIVATE lib1 [lib2 ...]
        )
        
    function and a new signature:
    
        ecm_add_tests(test1.cpp test2.cpp 
            TARGET_NAMES_VAR tgts
        )
        ecm_targets_link_libraries(${tgts}
            PRIVATE Qt5::Widgets Qt5::Test
        )


- Stephen Kelly


On May 18, 2015, 6:15 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123841/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 6:15 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Bugs: 345797
>     http://bugs.kde.org/show_bug.cgi?id=345797
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Rework ECMAddTests documentation to emphasis ecm_add_tests().
> 
> ecm_add_test is the less useful (and less used) version of the functions
> (because you really might as well just use add_executable() and
> add_test() manually in that case).
> 
> 
> Add arguments to ecm_add_tests for listing added tests.
> 
> This makes it convenient to make further modifications to the tests,
> such as setting properties on either the tests or the targets.
> 
> CHANGELOG: New arguments for ecm_add_tests().
> BUG: 345797
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddTests.cmake bdb606919b49d5d8400a7d49935c0f569d279076 
>   tests/ECMAddTests/multi_tests/CMakeLists.txt ca43477359fbfb8d41b1bb2ad08aeb3e75c99a1c 
>   tests/test_helpers.cmake 73be343e5a9fe603e8c4ba042c833d3f9360b6df 
> 
> Diff: https://git.reviewboard.kde.org/r/123841/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests, which pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150518/a1e4d0f3/attachment.html>