Review Request 123722: Add PROPERTIES argument to ecm_add_test and ecm_add_tests.

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123722/#review80285
-----------------------------------------------------------

Ship it!


LGTM

I ported modemmanger-qt to PROPERTIES in https://git.reviewboard.kde.org/r/123768/ and it works as well.

- Harald Sitter


On May 11, 2015, 6:33 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123722/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 6:33 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Bugs: 345797
>     http://bugs.kde.org/show_bug.cgi?id=345797
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add PROPERTIES argument to ecm_add_test and ecm_add_tests.
> 
> This is particularly useful with ecm_add_tests, where you may want to
> force a suite of tests to run in serial, or alter the timeout for
> multiple tests at once.
> 
> BUG: 345797
> 
> 
> Also:
> 
> Add unit tests for ECMAddTests module.
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddTests.cmake de06315d589eb8954cc18810f5dff922161fcfec 
>   tests/CMakeLists.txt bc3e5ce8157cdbcc7d4285344898afd948432de3 
>   tests/ECMAddTests/CMakeLists.txt PRE-CREATION 
>   tests/ECMAddTests/check_files.cmake PRE-CREATION 
>   tests/ECMAddTests/multi_tests/CMakeLists.txt PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test1.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test10.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test11.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test2.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test3.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test4.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test5.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test6.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test7.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test8.cpp PRE-CREATION 
>   tests/ECMAddTests/multi_tests/test9.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/CMakeLists.txt PRE-CREATION 
>   tests/ECMAddTests/single_tests/test1.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/test2.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/test3.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/test4.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/test5.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/test6.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/test6body.cpp PRE-CREATION 
>   tests/ECMAddTests/single_tests/test7.cpp PRE-CREATION 
>   tests/ECMAddTests/testhelper.h PRE-CREATION 
>   tests/ECMAddTests/testhelper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123722/diff/
> 
> 
> Testing
> -------
> 
> Newly-created unit tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150513/2a6dfb1a/attachment.html>