Review Request 122626: Use Qt5::lconvert when it is available
Dmitry Shachnev
mitya57 at gmail.com
Thu Mar 5 17:26:46 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122626/
-----------------------------------------------------------
(Updated Март 5, 2015, 5:26 п.п.)
Review request for Build System, Aurélien Gâteau and Harald Sitter.
Changes
-------
OK, added what Alex suggested.
Summary (updated)
-----------------
Use Qt5::lconvert when it is available
Repository: extra-cmake-modules
Description (updated)
-------
Qt5LinguistToolsConfig.cmake defines CMake target for `lconvert` since Qt 5.3.1, so we should use that if it is available.
Our own hacks were not working in some configurations (i.e. when there is `/usr/bin/lconvert` managed by qtchooser, but no qtchooser configuration file).
Diffs (updated)
-----
modules/ECMCreateQmFromPoFiles.cmake 3f134fb
modules/ECMPoQmTools.cmake 015b7f9
Diff: https://git.reviewboard.kde.org/r/122626/diff/
Testing
-------
Build qapt in clean Debian sid chroot. Previously it was failing with qtchooser error, now succeeds.
Thanks,
Dmitry Shachnev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150305/aaf7d6bc/attachment.html>
More information about the Kde-buildsystem
mailing list