Review Request 122626: Drop the hacks to find path to lconvert manually

Dmitry Shachnev mitya57 at gmail.com
Tue Mar 3 11:11:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122626/
-----------------------------------------------------------

(Updated März 3, 2015, 11:11 vorm.)


Review request for Build System, Aurélien Gâteau and Harald Sitter.


Repository: extra-cmake-modules


Description
-------

The old hacks were not working in some configurations (i.e. when there is `/usr/bin/lconvert` managed by qtchooser, but no qtchooser configuration file).

Qt5LinguistToolsConfig.cmake defines CMake target for `lconvert` since Qt 5.3.1, so we can use that instead.


Diffs
-----

  modules/ECMCreateQmFromPoFiles.cmake 3f134fb 
  modules/ECMPoQmTools.cmake 015b7f9 

Diff: https://git.reviewboard.kde.org/r/122626/diff/


Testing
-------

Build qapt in clean Debian sid chroot. Previously it was failing with qtchooser error, now succeeds.


Thanks,

Dmitry Shachnev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150303/7d163759/attachment.html>


More information about the Kde-buildsystem mailing list