Review Request 124106: Improve error reporting of query_qmake macro

David Edmundson david at davidedmundson.co.uk
Tue Jun 23 21:02:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124106/#review81715
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On June 23, 2015, 8:56 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124106/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 8:56 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Rohan Garg.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> In case it fails, offer an error message and the attempted call, to make sure we can react accordingly.
> 
> 
> Diffs
> -----
> 
>   modules/ECMQueryQmake.cmake c880671 
> 
> Diff: https://git.reviewboard.kde.org/r/124106/diff/
> 
> 
> Testing
> -------
> 
> I could fix the error I was finding.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150623/97252ff3/attachment.html>


More information about the Kde-buildsystem mailing list