Review Request 124104: Make it possible to use kconfig_compiler from different sources

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124104/#review81501
-----------------------------------------------------------


+1 on the idea from me.  I don't know CMake well, so I'd prefer to have a CMake guru +1 this RR.  I do have a note below, but it isn't a blocker.


src/kconfig_compiler/CMakeLists.txt (line 16)
<https://git.reviewboard.kde.org/r/124104/#comment55869>

    Does this mean a cross-compiled KConfig won't be built right for development on the target?  If this happens regardless, is the cross compiling still possible?
    
    My CMake foo is weak, so if no one knows an alternative, I'm fine.  I'd just prefer KConfig to work on the target for development too.


- Matthew Dawson


On June 15, 2015, 1:59 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124104/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 1:59 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald Sitter.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Separates the tooling that is supposed to be used at run-time so that we can specify which to use explicitly.
> 
> Ideally this would be done automagically, for now we'll have to specify -DKF5ConfigCompiler_DIR=...
> 
> Additionally, we should make kconfig_compiler co-installable by putting it in libexec, but I'd prefer to do that in a future patch. This same process should also happen on other frameworks.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f510e3e 
>   KF5ConfigConfig.cmake.in b4e5f56 
>   src/kconfig_compiler/CMakeLists.txt ec4a733 
> 
> Diff: https://git.reviewboard.kde.org/r/124104/diff/
> 
> 
> Testing
> -------
> 
> Works as expected on my debian chroot environment.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150616/5aee1aa8/attachment-0001.html>