Review Request 122135: Add ecm_add_app_icon function.

[Ralf Habacker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122135/#review74653
-----------------------------------------------------------

Ship it!



modules/ECMAddAppIcon.cmake
<https://git.reviewboard.kde.org/r/122135/#comment51737>

    pixel size 22 is not used in the code and should be removed here



modules/ECMAddAppIcon.cmake
<https://git.reviewboard.kde.org/r/122135/#comment51736>

    trailing whitespace



modules/ECMAddAppIcon.cmake
<https://git.reviewboard.kde.org/r/122135/#comment51735>

    trailing whitespace



modules/ECMAddAppIcon.cmake
<https://git.reviewboard.kde.org/r/122135/#comment51734>

    This should also be ${CMAKE_CURRENT_SOURCE_DIR}


windows support otherwise looks good.

- Ralf Habacker


On Jan. 24, 2015, 11:11 vorm., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122135/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 11:11 vorm.)
> 
> 
> Review request for Extra Cmake Modules, Ralf Habacker and Jeremy Whiting.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This adds an application icon to an executable from PNG files for
> Windows and Mac OS X. Unlike the similar kde4_add_app_icon macro from
> kdelibs, this requires icons to be explicitly listed as arguments
> (meaning CMake can tell when ones are added or deleted and reconfigure
> as appropriate), and it works with Matthias Benkmann's png2ico tool, as
> well as the KDE-Win tool of the same name.
> 
> Currently missing unit tests. Also completely untested (except that
> `make test` runs on Linux, so there are no obvious syntax errors).
> 
> With thanks to Ralf Habacker for the initial work on porting
> kde4_add_app_icon.
> 
> CHANGELOG: Add ECMAddAppIcon module to add icons to executable targets
> on Windows and Mac OS X.
> 
> 
> Diffs
> -----
> 
>   docs/find-module/FindPng2Ico.rst PRE-CREATION 
>   docs/module/ECMAddAppIcon.rst PRE-CREATION 
>   find-modules/FindPng2Ico.cmake PRE-CREATION 
>   modules/ECMAddAppIcon.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122135/diff/
> 
> 
> Testing
> -------
> 
> `make test` passes, which just provides a very basic check for syntax errors.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150124/13b43b20/attachment.html>