Review Request 121448: Introduce ECMAddAppIcon.
Jeremy Whiting
jpwhiting at kde.org
Fri Jan 16 22:00:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121448/#review74164
-----------------------------------------------------------
Ralf, Can you update the diff rather than uploading the file? It's much easier to apply a diff than to figure out where to put this file and if any other changes are needed to use it, etc.
- Jeremy Whiting
On Dec. 15, 2014, 1:01 a.m., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121448/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2014, 1:01 a.m.)
>
>
> Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> This module, which has been migrated from the related KDE4 macto kde4_app_app_icon,
> supports platform specific application icon for Windows and Mac OSX.
>
> On Windows this function depends on the external tool png2ico, which is
> provided by the kdewin-tools binary package. Sources are available at
> https://projects.kde.org/projects/kdesupport/kdewin.
>
>
> Diffs
> -----
>
> modules/ECMAddAppIcon.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121448/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8b3e226f-a70b-4998-983a-813730a436bf__ECMAddAppIcon.cmake
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8433995f-b88f-426d-af54-46aba635ae1e__ECMAddAppIcon.cmake
>
>
> Thanks,
>
> Ralf Habacker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150116/6d2c59db/attachment-0001.html>
More information about the Kde-buildsystem
mailing list