Review Request 121978: Don't unset old-style variables in KDEInstallDirs.cmake.

Kevin Kofler kevin.kofler at chello.at
Sun Jan 11 12:57:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121978/
-----------------------------------------------------------

(Updated Jan. 11, 2015, 12:57 nachm.)


Status
------

This change has been discarded.


Review request for Extra Cmake Modules.


Bugs: 342717
    http://bugs.kde.org/show_bug.cgi?id=342717


Repository: extra-cmake-modules


Description
-------

Do not unset old-style variables in KDEInstallDirs.cmake, it breaks projects using GNUInstallDirs for some parts and KDEInstallDirs for others.


Diffs
-----

  kde-modules/KDEInstallDirs.cmake 7d592af 

Diff: https://git.reviewboard.kde.org/r/121978/diff/


Testing
-------

Without the patch, the Calamares build in Fedora Rawhide fails.
With the patch, the Calamares build in Fedora Rawhide succeeds.


Thanks,

Kevin Kofler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150111/b50fed35/attachment.html>


More information about the Kde-buildsystem mailing list