Review Request 121978: Don't unset old-style variables in KDEInstallDirs.cmake.

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121978/#review73725
-----------------------------------------------------------


Ah, I see, unsetting cache variables that might be used in independent parts of the tree is dangerous. I don't think the fix is quite this simple though - if the unset()s are removed, the logic of determining the variable value should also be changed so that `KDE_INSTALL_*` is considered first, and the old-style variables last, so that subsequent changes to `KDE_INSTALL_FOO` (via the CMake GUI, for example) are not lost.

- Alex Merry


On Jan. 11, 2015, 3:55 a.m., Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121978/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2015, 3:55 a.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Bugs: 342717
>     http://bugs.kde.org/show_bug.cgi?id=342717
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Do not unset old-style variables in KDEInstallDirs.cmake, it breaks projects using GNUInstallDirs for some parts and KDEInstallDirs for others.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake 7d592af 
> 
> Diff: https://git.reviewboard.kde.org/r/121978/diff/
> 
> 
> Testing
> -------
> 
> Without the patch, the Calamares build in Fedora Rawhide fails.
> With the patch, the Calamares build in Fedora Rawhide succeeds.
> 
> 
> Thanks,
> 
> Kevin Kofler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150111/0e5be053/attachment.html>