Review Request 126185: Make the KAppTemplate CMake module global

Marco Martin notmart at gmail.com
Wed Dec 16 12:25:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 12:25 p.m.)


Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter.


Changes
-------

rename done, stuck on the failing test


Repository: extra-cmake-modules


Description
-------

templates are very useful as teaching tool in order to make
a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks


Diffs (updated)
-----

  kde-modules/KDEInstallDirs.cmake b7cd34d 
  kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
  tests/CMakeLists.txt 1a66f56 
  tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126185/diff/


Testing
-------

done some templates installed by plasma-framework


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151216/b436bd23/attachment.html>


More information about the Kde-buildsystem mailing list